Relatively early CS career (SE II): Advice not getting defensive during senior code review? /u/whatacad CSCQ protests reddit

At my company, I’ve been slow to adapt to the code base (new languages, first time more focused on maintaining existing code/fixing patches, first time working with front end), and it’s given my senior engineer the impression that I can’t be trusted to know what I’m doing (I’ve been a product owner and have led teams/roadmaps before). They will take ages to look at my PRs or bypass my suggested solution with their own approach. I will compensate by writing out step by step processes in issues and PRs to try and articulate my thoughts but it feels like I’m not trusted/respected. It doesn’t help that we don’t really get along. I’ve already had a meeting with them to discuss our differing communication/work styles.

Some of this is on me, as this is the first time I’ve had to deal with someone seriously critiquing my PRs. I also have some pride I’m bringing in, having led projects/teams in previous roles. I will catch myself assuming the worst before anything has been said/find myself getting defensive at their comments. Does anyone have any advice for getting over preemptively getting defensive/not taking things personally?

submitted by /u/whatacad
[link] [comments]

​r/cscareerquestions At my company, I’ve been slow to adapt to the code base (new languages, first time more focused on maintaining existing code/fixing patches, first time working with front end), and it’s given my senior engineer the impression that I can’t be trusted to know what I’m doing (I’ve been a product owner and have led teams/roadmaps before). They will take ages to look at my PRs or bypass my suggested solution with their own approach. I will compensate by writing out step by step processes in issues and PRs to try and articulate my thoughts but it feels like I’m not trusted/respected. It doesn’t help that we don’t really get along. I’ve already had a meeting with them to discuss our differing communication/work styles. Some of this is on me, as this is the first time I’ve had to deal with someone seriously critiquing my PRs. I also have some pride I’m bringing in, having led projects/teams in previous roles. I will catch myself assuming the worst before anything has been said/find myself getting defensive at their comments. Does anyone have any advice for getting over preemptively getting defensive/not taking things personally? submitted by /u/whatacad [link] [comments] 

At my company, I’ve been slow to adapt to the code base (new languages, first time more focused on maintaining existing code/fixing patches, first time working with front end), and it’s given my senior engineer the impression that I can’t be trusted to know what I’m doing (I’ve been a product owner and have led teams/roadmaps before). They will take ages to look at my PRs or bypass my suggested solution with their own approach. I will compensate by writing out step by step processes in issues and PRs to try and articulate my thoughts but it feels like I’m not trusted/respected. It doesn’t help that we don’t really get along. I’ve already had a meeting with them to discuss our differing communication/work styles.

Some of this is on me, as this is the first time I’ve had to deal with someone seriously critiquing my PRs. I also have some pride I’m bringing in, having led projects/teams in previous roles. I will catch myself assuming the worst before anything has been said/find myself getting defensive at their comments. Does anyone have any advice for getting over preemptively getting defensive/not taking things personally?

submitted by /u/whatacad
[link] [comments] 

Leave a Reply

Your email address will not be published. Required fields are marked *