Am I being a toxic code reviewer? /u/SereneCalathea CSCQ protests reddit

My philosophy as a code reviewer is to generally focus on logical mistakes or bugs, rather than subjective things like what should or shouldn’t be a function, how things should be organized, or things that should be managed by a linter.

I’ve recently received feedback that, while they weren’t implying that what I was doing was wrong, that it can be frustrating having code reviewed by me because I tend to find a lot of bugs that normally would have passed code review before I joined the team, and it makes my coworkers feel like they have to work harder or that they’re being too lazy.

I try really hard to make sure that I don’t come across as condescending because I’ve been told that before when I was in college. I try to make sure: – I use the word “we” instead of “you” as much as possible to emphasize that it’s a “team-working-together-to-make-code-better thing” – I try to make my comments sound like suggestions by starting them with things like “What do you think of doing so and so?”

Should I start letting certain bugs through if I don’t think the bugs aren’t important, especially since the work culture at my company is extremely relaxed and laid back? I don’t want to seem like a brown noser, and I don’t want to stick out too much and make my coworkers hate me.

One thing I considered is to start finding things to compliment in code reviews, since I don’t do that at all, but it feels difficult for me to do that because I don’t even review my own code that I write that way… I tend to be extremely critical of the things that I do myself, and maybe that exposes itself on how I review code.

My philosophy as a code reviewer is to generally focus on logical mistakes or bugs, rather than subjective things like what should or shouldn’t be a function, how things should be organized, or things that should be managed by a linter.

I’ve recently received feedback that, while they weren’t implying that what I was doing was wrong, that it can be frustrating having code reviewed by me because I tend to find a lot of bugs that normally would have passed code review before I joined the team, and it makes my coworkers feel like they have to work harder or that they’re being too lazy.

I try really hard to make sure that I don’t come across as condescending because I’ve been told that before when I was in college. I try to make sure: – I use the word “we” instead of “you” as much as possible to emphasize that it’s a “team-working-together-to-make-code-better thing” – I try to make my comments sound like suggestions by starting them with things like “What do you think of doing so and so?”

Should I start letting certain bugs through if I don’t think the bugs aren’t important, especially since the work culture at my company is extremely relaxed and laid back? I don’t want to seem like a brown noser, and I don’t want to stick out too much and make my coworkers hate me.

One thing I considered is to start finding things to compliment in code reviews, since I don’t do that at all, but it feels difficult for me to do that because I don’t even review my own code that I write that way… I tend to be extremely critical of the things that I do myself, and maybe that exposes itself on how I review code.