Junior dev – PRs take forever to get merged /u/undefined6346634563 CSCQ protests reddit

I started working a new project two months ago where I’m the sole SWE working on implementation and I’m writing a lot of new code for a new microservice. There’s about 6 people who are familiar with the area I’m working in and who can contribute to reviewing my PRs.

So far, it takes 3-4 weeks before anyone even makes time to look at them. When one of them does finally get around to it, I always address their comments on the same day or the next day but they won’t touch the PR again for another week at least. And one of the guys literally just fires and forgets – skims my PRs, leaves a handful of cursory comments, and then never touches them again lol.

For the record, I don’t think it’s a problem of code quality or PR size – I’ve been consistently getting feedback from my coworkers during performance reviews that I write high-quality code and only a small fraction of the PR comments I’ve been getting are really about code quality or even design. It’s generally minor things, people pushing their personal preferences, and questions about how things fit into the big picture and the reasoning behind implementation decisions. Also I put effort into breaking down PRs into logical chunks so the diffs aren’t absurdly large. For example if a non-trivial library change can be reviewed in isolation then I’ll put that in its own PR instead of bundling it with a whole bunch of other changes.

I started DMing people every few days on Slack to take a look but they either ignore me or keep saying that they’ll get around to it when they have time. I’m not really sure what to do about this but I find it very frustrating. The manager I’m working under for this project has been brushing me off saying that everyone is busy, but at the current rate of merging PRs we’re pretty much guaranteed to miss our deadline. I honestly don’t care about the deadline or the project at this point but I’m sure it’ll reflect poorly on me. Any advice?

I started working a new project two months ago where I’m the sole SWE working on implementation and I’m writing a lot of new code for a new microservice. There’s about 6 people who are familiar with the area I’m working in and who can contribute to reviewing my PRs.

So far, it takes 3-4 weeks before anyone even makes time to look at them. When one of them does finally get around to it, I always address their comments on the same day or the next day but they won’t touch the PR again for another week at least. And one of the guys literally just fires and forgets – skims my PRs, leaves a handful of cursory comments, and then never touches them again lol.

For the record, I don’t think it’s a problem of code quality or PR size – I’ve been consistently getting feedback from my coworkers during performance reviews that I write high-quality code and only a small fraction of the PR comments I’ve been getting are really about code quality or even design. It’s generally minor things, people pushing their personal preferences, and questions about how things fit into the big picture and the reasoning behind implementation decisions. Also I put effort into breaking down PRs into logical chunks so the diffs aren’t absurdly large. For example if a non-trivial library change can be reviewed in isolation then I’ll put that in its own PR instead of bundling it with a whole bunch of other changes.

I started DMing people every few days on Slack to take a look but they either ignore me or keep saying that they’ll get around to it when they have time. I’m not really sure what to do about this but I find it very frustrating. The manager I’m working under for this project has been brushing me off saying that everyone is busy, but at the current rate of merging PRs we’re pretty much guaranteed to miss our deadline. I honestly don’t care about the deadline or the project at this point but I’m sure it’ll reflect poorly on me. Any advice?